Bitcoin full node and query server

March 2022

Archive of the libbitcoin Slack #general channel.

Thursday, March 3, 2022

pmienk20:15
Topic: Dev Weekly Status Time: Mar 3, 2022 01:00 PM Pacific Time (US and Canada) Please download and import the following iCalendar (.ics) files to your calendar system. Weekly: https://us05web.zoom.us/meeting/tZEvdOuhqDojH9D-BdyHorKbDmxpqSsVUDme/ics?icsToken=98tyKuGtrDgoE9KUuRyDRpwMAIjCa_Pwpn5Egvp50T3hGghccCj0Eu9aIqNMA-7l Join Zoom Meeting https://us05web.zoom.us/j/85232961954?pwd=ME5jenh0YWlqUFJlcXptMndxYml4QT09 Meeting ID: 852 3296 1954 Passcode: Et0zKR
👍🏾 1

Saturday, March 5, 2022

jungly18:25
@evoskuil @pmienk following the conversation on trying out clang-format, I had a go. Here's a PR: https://github.com/evoskuil/libbitcoin-system/pull/13 The rules in clang-format are a starting point. If you can look at what doesn't work, I can try and make changes to clang-format rules to try and get as close to what we want. I started with 'Microsoft' styles that ship with clang-format and made some minor changes to conform to some of our existing styles. Then I thought, it might be best to bring this here to see how much more we want to tweak.
2 replies · jungly, evoskuil · last Mar 07, 2022
jungly18:26
The cool thing is, almost all editors support "format code on save" according to clang-format. And there are github actions that allow us to validate format conforms to the clang-format rules as part of the CI pipeline.
evoskuil21:12
Cool, thanks.

Thursday, March 10, 2022

pmienk20:27
Topic: Dev Weekly Status Time: Mar 10, 2022 01:00 PM Pacific Time (US and Canada) Join Zoom Meeting https://us05web.zoom.us/j/85232961954?pwd=ME5jenh0YWlqUFJlcXptMndxYml4QT09 Meeting ID: 852 3296 1954 Passcode: Et0zKR
evoskuil21:44
🕺🏻
👍 1🤣 1
jungly21:45
Never got to hear what you thought about the clang-format PR!
evoskuil21:46
Haven't looked at it yet.
jungly21:47
Cool. Would love to hear if we should try to work towards a autoformatter or ditch that effort.
pmienk21:48
Looked good but for the ordering of headers. It's fighting with the generated stuff and interspersing libbitcoin and dependency headers. my understanding was internal header references came last. as for directories, the ordering appears opposite to the generation ordering
3 replies · jungly · last Mar 11, 2022
jungly14:45
The includes sorting was going to get too complex. For now, I decided to ask clang-formatter to don't try and sort includes
jungly14:46
The system/internal sorting was easy. The sort order for directories would require too much configuration in .clang-format, and I decided it wasn't worth the effort. We want this:
#include <bitcoin/system/constants.hpp>
#include <bitcoin/system/constraints.hpp>
#include <bitcoin/system/chain/block.hpp>
#include <bitcoin/system/chain/chain.hpp>
But .clang-format would do the following because chain comes before constants.
#include <bitcoin/system/chain/block.hpp>
#include <bitcoin/system/chain/chain.hpp>
#include <bitcoin/system/constants.hpp>
#include <bitcoin/system/constraints.hpp>
We can make it work, but we'd have to paste tonnes of directory paths into .clang-format and give them priorities. It'll just be another shit to maintain. We just trust our eyeballs sorting for now.
(edited)
jungly21:48
There's an option to order those. I can fix that.
evoskuil21:48
I like it, but just not much of a priority for me right now, as it can be applied at any time without additional difficulty.
jungly21:49
Yeah. Agreed that it can come at any point later in time. Hopefully it makes it easier to collaborate.

Thursday, March 17, 2022

pmienk19:32
Topic: Dev Weekly Status Time: Mar 17, 2022 01:00 PM Pacific Time (US and Canada) Join Zoom Meeting https://us05web.zoom.us/j/85232961954?pwd=ME5jenh0YWlqUFJlcXptMndxYml4QT09 Meeting ID: 852 3296 1954 Passcode: Et0zKR
👍🏻 1👍🏾 1
jungly20:05
@evoskuil won't hog the call, but I'll be asking some questions about the difference between create endoresement and the new approach to use the check sig verify code 😁
evoskuil20:06
kk
evoskuil20:48
@jungly are you joining?
jungly20:48
Aye. Starting in 15, no?
evoskuil20:49
now
jungly20:49
Joining
pmienk21:31
my head's throbbing, going to lie down. if you two want to continue on your own there isn't a time limit on zoom
evoskuil21:32
K, I think we're done. Get some rest. 🙂
✔️ 1
jungly21:45
@evoskuil you meant SWIG, right?
evoskuil21:46
Ahhh - yes

Thursday, March 24, 2022

pmienk19:30
Topic: Dev Weekly Status Time: Mar 24, 2022 01:00 PM Pacific Time (US and Canada) Join Zoom Meeting https://us05web.zoom.us/j/85232961954?pwd=ME5jenh0YWlqUFJlcXptMndxYml4QT09 Meeting ID: 852 3296 1954 Passcode: Et0zKR

Thursday, March 31, 2022

pmienk19:30
Topic: Dev Weekly Status Time: Mar 31, 2022 01:00 PM Pacific Time (US and Canada) Join Zoom Meeting https://us05web.zoom.us/j/85232961954?pwd=ME5jenh0YWlqUFJlcXptMndxYml4QT09 Meeting ID: 852 3296 1954 Passcode: Et0zKR
3 replies · jungly, pmienk, neillm · last Mar 31, 2022
jungly19:31
Travelling to Paris early tomorrow morning! Off to run a marathon! So going to miss this tonight!
pmienk19:31
no worries, good luck
🙏🏾 1
neillm19:36
Not me either 😞
evoskuil19:35
Hey, can't make it today.
pmienk19:36
okay, if it's just me, i'll go back to normalizing the install script(s)
💪🏾 1🎉 1