Apr 1, 2021

Dear Eric, After pondering for a while we now realize what the join() from thread remark in the code regards. We suggest this slight clarification: What about “// This must be called from the thread that constructed this class (see join).” -> “// This must be called from the thread that constructed this class (see join). // Specifically, threadpool.join() will be invoked and for it to work, the threadpool.join() // call must be made from a thread that is not itself a part of the LibBitcoin threadpool. // An example of such a thread, is the OS process’ main thread, from which this // class was created.” https://github.com/libbitcoin/libbitcoin-node/blob/master/src/full_node.cpp#L357 https://github.com/libbitcoin/libbitcoin-node/blob/master/console/executor.cpp#L220