Apr 8, 2024

ok i will start reading there

Feel free to post questions/comments.

ok i can't install... i'm on a Mac M2, i pass until make (i compiled bitcoin-core/secp256k1 first). the error it gives me is:

./include/bitcoin/system/intrinsics/haves.hpp:114:16: error: use of undeclared identifier 'get_cpu' return get_cpu(eax, ebx, ecx, edx, cpu1_0::leaf, cpu1_0::subleaf)

and several similar more

deleted a post where I had you confused with another...

You should build libsecp from our repo (for versioning).

Core doesn't version it. This works for them because they clone the sources into the bitcoin repo. But for anyone who wants to use it as a proper library, versioning is required. They introduce unversioned breaking changes that otherwise break our builds.

If you want to build from their repo you need to target the right commit.

oh ok makes sense

no particular reason to use their version so i will go for libbitcoin version

current master branch?

Can you give me a few more of the error lines?

I think I see what it is, but I'm not sure why we aren't seeing it in CI.

Is there an error on get_xcr?

oh, i compiled and installed sec256k from libbitcoin and now it says this ./configure: checking for libsecp256k1 >= 0.1.0.20... no configure: error: libsecp256k1 >= 0.1.0.20 is required but was not found.

FYI install.sh will download and build everything, it's what we use in CI.

i think didn't show but i have to get to make again

oh

thanks

The link defaults to /version3 (released) so if you want /master (👍🏻) get the install.sh from master.

ok i should have read with a little more attention

We don't modify libsecp to version it, we just place it into different branches. That's why you got an error from master.

ok

/master/libbitcoin requires /version8/libsecp

i'm trying now wiht install script

What class of CPU does your Mac have?

ARM right?

yeah

a M2

That explains it. We don't CI on ARM.

oh

It's a bug, and I can patch it right now. But you may have to work through more. That would be fine with me. We just haven't got that CI set up yet.

That's our latest set of CI builds for libbitcoin-system.

autotools, cmake, clang, xcode, visual studio on X86 linux, macos, windows

It's a lot 🙂

We're planning on big endian and ARM also.

The particular bug is in the setup of compiler-specific optimizations. non-Intel/AMD had an issue where a call was execution excluded but not from compile.

ok

ok, so could be a good idea try from that branch?

From that branch with the PR included. I'll merge it once it clears CI.

oh

In file included from ./boost/mpl/integral_c.hpp:32: ./boost/mpl/aux_/integral_wrapper.hpp:73:31: error: integer value -1 is outside the valid range of values [0, 3] for this enumeration type [-Wenum-constexpr-conversion] ./boost/mpl/aux_/static_cast.hpp:24:47: note: expanded from macro 'BOOST_MPL_AUX_STATIC_CAST' # define BOOST_MPL_AUX_STATIC_CAST(T, expr) static_cast<T>(expr) ^ 2 errors generated. ...failed updating 3 targets...

merged

oh the CI takes a lot haha

It's just 1 of 10 repos 🙂

Did you build boost or rely on your local boost?

ok haha

i install with homebrew.... for what i see probably better to build myself

with clang 15

Yes, boost is always a problem with conflicts.

The installer has a build boost option, and also recommend static linking.

also avoid installing to a shared directory. Best to isolate the whole build.

thanks for the help, i will try some workaround for this

for what?

the boost issue?

That's likely a boost compatibility issue and should be resolved by building it as shown above.

boost and libsecp are the only required dependencies and build from the install.sh. Also ICU which is optional.

the error gets again with this:https://libbitcoin.slack.com/archives/C6LH74ACQ/p1712783523195809?thread_ts=1712597441.375849&cid=C6LH74ACQ

The boost error?

yeah

Can you post the build log?

this?

This is a compiler warning elevated to error by strict processing.

You are probably seeing it where we don't because you are on clang15 and we build with 14.

You might try bumping the boost version, as they may have fixed it. Though that sometimes surfaces other issues.

Details here: https://github.com/boostorg/mpl/issues/69

We build with clang14 on macos and clang15 on linux. The issue is a consequence of a llvm breaking change in clang16 that breaks boost and has no fix. You said you are on clang15 - which shouldn't be an issue. But I would try 14 if that's the case, since that's what we test with.

Any luck?

i couldn't try, i have had lots of things going on but i want to try again soon