Oct 30, 2024

After resetting the same store to the pre-validation state (using -r) and using a build that changes backlog measurement to blocks vs. tx count, the visible CPU valleys are gone. This makes sense because the query to obtain a block's tx count, as it is queued and again dequeued (the deque could have been passed via closure as an optimization), is a hashmap search, and has a material cost. This also changes the buffer limit from a hardwired tx-based value of about 5M to a simple block window, and uses the concurrency_window setting for that purpose (since the values reasonably related to perf, and this use isn't too significant).